[DX] Detach typo3 from core to allow stable growth of both packages #2446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
changed the title
TomasVotruba
changed the title
|
@simonschaufi Hi, I believe you're now maintaining the project, so this is important to upgrade for your next release. |
|
I'm merging this, so you can use |
|
As a unintentional side effect, Rector build now dropped from 4:50 to 3:40, that's 25 % faster 👍 Before
Now
|
|
I'm just a contributor to the project like @helsner but @sabbelasichon is still the project lead. I didn't take over the project and I don't want that actually 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last 3 months I've been working on upgrade of Rector and it caused me to duplicate lot of work directly in typo3 Rector. The reason is typo3 Rector uses
rector/rector-srcdev-main. It is very unstable and any commit here can break it. And many times it did :(On the otherside, the typo3 Rector depens on many external packages, that are not useful for the other rector/rector users. Because of current architecture, they're forced to download it and whole prefixed Rector is shipped with those.
That's stressful for both sides and shows bad architecture.
Instead, external package like should use
rector/rectorand build on top of that.There are many existing 3rd party extensions that work well this way:
Please follow their architecture for inspiration.
How to change typo3-rector? Basically it requires change of external dependency and updating related services:
{ "require": { - "rector/rector-src": "dev-main" + "rector/rector": "^0.13.4" } }I belive this will allow both packages to grow closer to their domain and help their own communities closer, with their own specific problems 🙏 👍